-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document how to remove the automatic white background for images with the dark theme #879
Comments
I think the question here comes down to deciding which is more common:
My feeling was that the second option is more common which is why we added this (we got several reports of people saying that their plot outlines etc didn't show up properly because they were in black). But if others generally disagree we can figure out another way around this, maybe with a config flag or something? |
I agree with your guess I just wanted to check if other would agree with a config parameter |
a config parameter seems reasonable to me - though couldn't you also just turn this off with your own manual CSS? e.g.: .bd-content img:not(.only-dark) {
background: unset;
} |
That is also my impression
I had the same thought. IMO either we provide a config flag or we provide a CSS snippet in the docs so users don't have to figure it out themselves. Slight preference for the latter |
This is what I did in my own documentation (openforis/sepal-doc@cb30410). fine by me as well |
I didn't follow when this modification was included but this morning all the images of my documentation has gained a white background.
Experimenting a bit I realized that the images that have not the "only-dark" class are automatically earning this new white colored background. In the case of my documentation that is using images that work for both I don't need such a change and I don't want to duplicate my images or add extra parameter to every figures to leave them as they are.
Is there a global html parameter to deactivate this modification ?
Is it really needed ?
pydata-sphinx-theme/src/pydata_sphinx_theme/assets/styles/variables/_color.scss
Line 114 in 6f14f45
The text was updated successfully, but these errors were encountered: