-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Add skip to main content button for a11y #1019
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great - thanks! Just a few comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me - will merge it in and we can iterate from there if there is more feedback
I have some issues with this on my Chromium 103 running under CentOS 7. The bar is always visible. Not sure if there is anything to do on your side though or if I just have to live with this (hiding all the Matplotlib menu items)? Yes, they are old, but for certain scenarios one needs to run specific OS... Is there a way to disable this is the settings? I understand that it is useful from an accessibility perspective, but I also guess that if the structure is reasonably simple anyway it may not be wanted/required. |
@oscargus here's one way to do it: |
Fix #966
respecting all the instructions from the video shared in the issue + some of our own css tricks (colors + z-index)