Fix icon links requirement #1231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drammock
approved these changes
Mar 4, 2023
|
ok gonna merge this one and cut a quick patch release so that folks don't keep getting hit by this. |
|
Ok. I have been having issues with this one. Glad that you worked that out. Thanks! |
|
thanks @choldgraf !! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the case that no icon links are given, and a github/gitlab/etc URL is given, and the logic assumed that icon_links wasn't
None.I think we might want to deprecate this "auto-add icon links" behavior soon, but this at least fixes the immediate bug.
icon_linksis required even if empty? #1226I tested locally by building the docs after commenting out our
icon_linksconfig. Onmainthis breaks, and on this PR it works. I thought this might be too edge-casey to warrant a full test esp since we don't really encourage the shortcut syntax for links