-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT: fixes to tabbed examples in docs #1379
Conversation
--- | ||
caption: '`conf.py`' | ||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this workaround prevents "conf.py" from being turned into a link to https://conf.py
I haven't been able to determine what causes the unwanted linking; I think it might be Myst-Parser because the caption "MANIFEST.in" on this page of the sphinx documentation does not become a link; so I'm wondering if it's an rST source versus MD source thing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes to this file add an overline to the tab labels on hover, so that we're not relying only on color change to signal interactivity. cc @trallard in case overlines are considered bad or there's some better way to signal this.
CIs are all green, this one's ready for review/merge. Here's a link to the tabbed example that changed the most: https://pydata-sphinx-theme--1379.org.readthedocs.build/en/1379/user_guide/static_assets.html#add-it-directly-to-the-page-content |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a nice improvement to me! I couldn't find any bugs in there. +1
Thank you! This is a component I had marked for improvements. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM sorry to have close the other PR prior to your review
follow-up to #1373, which was merged before I could get my review submitted