Fix version warning banner message #1394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drammock
added
kind: bug
|
This one is ready for review/merge. The PR build still looks as expected; the real test will be if https://pydata-sphinx-theme.readthedocs.io/en/latest/index.html shows the banner correctly after this PR is merged. |
|
it worked :)
|
|
yeah sorry I checked but I'm unable to send Images to Github from my company computer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes 2 problems with the version warning banner:
preferred)DOCUMENTATION_OPTIONS.VERSIONwhich sometimes is an empty string --- not sure why; on PR builds it is correctly populated but on current dev build it is empty string, yielding this screenshot: