Fix and change a11y tests #1687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @trallard |
trallard
added
the
tag: accessibility
trallard
approved these changes
Feb 12, 2024
drammock
approved these changes
Feb 12, 2024
There was a problem hiding this comment.
this looks like a nice improvement, thanks @gabalafou!
Long-term, I might consider splitting out the mapping of pagename -> expected/tolerated violation into a dict or other data structure that is external to the function, or maybe even storing it as a separate JSON or YAML file. I usually find that easier to maintain than the current design, where the various exceptional url_pathnames are written into the function code body.
That said, the landmark-unique situation is complicated and might not be easy to abstract out in the way I've just described. So I think for now let's go with what you've got here.
Co-authored-by: Tania Allard <taniar.allard@gmail.com>
ivanov
pushed a commit
to ivanov/pydata-sphinx-theme
that referenced
this pull request
Jun 5, 2024
* Fix and change a11y tests * Apply suggestions from code review Co-authored-by: Tania Allard <taniar.allard@gmail.com> * fix lint --------- Co-authored-by: Daniel McCloy <dan@mccloy.info> Co-authored-by: Tania Allard <taniar.allard@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the passing accessibility tests broke because of the way I had implemented the data regression fixtures for pytest-regressions in #1501.
Specifically, some of the data regression fixture files contained the Axe-core version, so when Axe-core was updated, those fixtures became out of sync with the test run.
I decided to scrap the data regression fixture files and instead, I define a function in the test file that filters out violations for Axe-core rules that we want to ignore. Using a function is ultimately more flexible.