Update release action #1803
Merged
Update release action #1803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(FWIW I did check that the versions of the upload/download artifact actions were all compatible, and they are (upload/download are both v4, and the package build action is v2 which should be the right one) |
|
@drammock I am sorry I missed the unpacking! I went ahead and pushed some slight changes (I hope you do not mind). And this should be good to go! 🚀 |
trallard
approved these changes
May 7, 2024
|
Thanks @trallard I'll look soon then try to cut another RC today |
|
release action works now! Except I forgot to bump the version number in |
ivanov
pushed a commit
to ivanov/pydata-sphinx-theme
that referenced
this pull request
Jun 5, 2024
* make permissions local to release job (safer) * use correct artifact name, and unzip * Fix download and extract package --------- Co-authored-by: Tania Allard <taniar.allard@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@trallard and @Carreau I think this will fix the release action (see #1758 (comment)), but it's late on a Friday and to test it I'd have to self-merge and then tag another release; seems prudent to wait for a second set of eyes.