Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spacing in admonitions #207

Merged
merged 1 commit into from
Jun 22, 2020
Merged

Conversation

choldgraf
Copy link
Collaborator

@choldgraf choldgraf commented Jun 20, 2020

This adds spacing for admonitions.

Demo it here: https://370-130237506-gh.circle-artifacts.com/0/html/demo/demo.html#admonitions

closes #201

@choldgraf
Copy link
Collaborator Author

OK I'm gonna merge this one in, since this is basically the implementation of the preview that @jorisvandenbossche +1'ed in #201 - I think it'll be easier to decide if we like the design after seeing it in action for a bit!

@choldgraf choldgraf merged commit b4a670f into pydata:master Jun 22, 2020
@choldgraf choldgraf deleted the admonition-space branch June 22, 2020 14:57
@jorisvandenbossche
Copy link
Member

Thanks!

@pradyunsg
Copy link
Contributor

Hmm... Comparing to https://squidfunk.github.io/mkdocs-material/reference/admonitions/, given that both follow the same style, I think I prefer the full-width variant from mkdocs-material. Would it be OK to drop the width: 95% added here?

@jorisvandenbossche
Copy link
Member

Personally I would be fine with that, not sure if @choldgraf had a specific reason to add the padding

@choldgraf
Copy link
Collaborator Author

I don't think I have a strong opinion here, was just trying to find ways to differentiate admonitions from the rest of the text because it felt visually cluttered to me, but happy to see what it looks like at 100

@pradyunsg
Copy link
Contributor

Hmm... Looks like I'll have to unbreak my npm setup to work on this project.

@jorisvandenbossche
Copy link
Member

Hmm... Looks like I'll have to unbreak my npm setup to work on this project.

What do you mean exactly?
(insights in / feedback on how smooth (or not) the contributing process goes is very welcome, as we know there are some potential roadblocks ..)

@pradyunsg
Copy link
Contributor

I'd borked my nvm / nodejs / brew installations a little while back and never fixed that trash fire because it was easier to step away and use Python-only tools.

I don't think the development workflow here is difficult by any means. It's just that I made a mess that I have to clean up. 🙃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Indent our admonitions a bit more
4 participants