Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scripts_end block and banner div to base layout.html #375

Merged
merged 1 commit into from
Apr 9, 2021

Conversation

jorisvandenbossche
Copy link
Member

Attempt to address some customization needs for bokeh, cfr bokeh/bokeh#11130 (comment)

cc @bryevdv

@bryevdv
Copy link
Contributor

bryevdv commented Apr 7, 2021

@jorisvandenbossche I might suggest instead something like extra_scripts at least for the usage in Bokeh, we want to add scripts in addition to the webpack and GA parts. Unless I'm mistaken the structure above would require copy and pasting those bits in order to keep them

@jorisvandenbossche
Copy link
Member Author

I think you can use super() to get the content of the parent block to be able to add something. See https://jinja.palletsprojects.com/en/2.11.x/templates/#super-blocks

@bryevdv
Copy link
Contributor

bryevdv commented Apr 7, 2021

Ah, in that case it seems 👍

@drammock
Copy link
Collaborator

drammock commented Apr 7, 2021

This will be useful for us too, thanks!

@jorisvandenbossche jorisvandenbossche merged commit 229e6bb into pydata:master Apr 9, 2021
@jorisvandenbossche jorisvandenbossche deleted the extra-blocks branch April 9, 2021 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants