Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ND being accepted as COO data. #386

Merged
merged 1 commit into from
Jul 29, 2020

Conversation

hameerabbasi
Copy link
Collaborator

@hameerabbasi hameerabbasi commented Jul 29, 2020

Fixes #385.

@codecov
Copy link

codecov bot commented Jul 29, 2020

Codecov Report

Merging #386 into master will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #386      +/-   ##
==========================================
- Coverage   94.17%   94.16%   -0.02%     
==========================================
  Files          19       19              
  Lines        2437     2586     +149     
==========================================
+ Hits         2295     2435     +140     
- Misses        142      151       +9     

@hameerabbasi hameerabbasi merged commit e682a8b into pydata:master Jul 29, 2020
@hameerabbasi hameerabbasi deleted the 2d-data-fix branch July 29, 2020 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

COO constructor accepts 2D data with shape (n, 1) which breaks other things
1 participant