-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
combine_first by using apply_ufunc in ops.fillna (#1204)
* First commit of ops.fillna() using apply_ufunc(). * Saving preliminary changes to fillna using apply_ufunc.aset attr test. * _yield_applied for GroupedBy.fillna(). Inspired by _binary_op(). * Finished introducing combine_first to DataArray/Dataset objects. Remove _fillna from injection. * Minor spacing changes to doc. * Use np.where() in ops.fillna * Separating data_vars_join from join in apply_ufunc, and accessing it through ops.fillna. Also added docstring. * Rewrote Groupby's fillna, among other review comments.git status * Initial attempt to introduce keep_attrs to apply_ufunc. * Adding test for data_vars_join, also removing join kwarg in fillna of dataarray.py and dataset.py. * Brining keep_attrs from apply_ufunc to apply_dataset_ufunc and apply_dataarray_ufunc. * Forcing explicit specification for dataset_fill_value. * Added test for keep_attrs. Changed kwarg name frmo data_vars_join to dataset_join. * Updated docstrings. Moving changes to v0.9.0 * Adjust dataset_fill_value default in apply_ufunc signature
- Loading branch information
1 parent
4bb630f
commit c5146e8
Showing
11 changed files
with
298 additions
and
52 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.