fix printing of unicode attributes #892
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| def _str_or_unicode(obj): | ||
| """A drop in replacement for str() which properly handles unicode. | ||
| """ | ||
| if isinstance(obj, unicode_type): |
There was a problem hiding this comment.
I think we actually want to handle this the other way around: convert everything to unicode (str on Python 3). Maybe something like:
if isinstance(obj, bytes):
obj = obj.decode('ascii')
return unicode_type(obj)
|
I just put up an alternative (with tests) in #914. |
|
Fixed by #914 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #834
I would welcome a suggestion of how to test this in a way that works with both python 2 and 3. This is somewhat outside my expertise.