Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix concatenating Variables with dtype=datetime64 #134

Merged
merged 6 commits into from
May 20, 2014
Merged

Fix concatenating Variables with dtype=datetime64 #134

merged 6 commits into from
May 20, 2014

Commits on May 19, 2014

  1. Fix concatenating of Variables with dtype=datetime64 

    This is a more direct fix for the bug @akleeman reported pydata#125.

Previously, it did not always work to modify Variable.values in-place (as done
in Variable.concat), because as_array_or_item could return a copy of an
ndarray instead of a view.

@akleeman I didn't incorporate your tests for the
    @shoyer
    shoyer committed May 19, 2014
    Configuration menu
    Copy the full SHA
    71f6662 View commit details
    Browse the repository at this point in the history

  2. Clean up variable._as_compatible_data

    @shoyer
    shoyer committed May 19, 2014
    Configuration menu
    Copy the full SHA
    5e63ab9 View commit details
    Browse the repository at this point in the history

  3. Don't copy datetime64 arrays unless they don't have ns precision

    @shoyer
    shoyer committed May 19, 2014
    Configuration menu
    Copy the full SHA
    cd1d02e View commit details
    Browse the repository at this point in the history

  4. Circumvent pandas dtype inference when indexing coordinates

    @shoyer
    shoyer committed May 19, 2014
    Configuration menu
    Copy the full SHA
    25de78a View commit details
    Browse the repository at this point in the history

  5. Fix array_equiv for 0-dimensional object arrays 

    This is a work-around for this upstream issue:
pandas-dev/pandas#7176
    @shoyer
    shoyer committed May 19, 2014
    Configuration menu
    Copy the full SHA
    2869cde View commit details
    Browse the repository at this point in the history

  6. Verify that index/concat does not change dtype for datetime variables

    @shoyer
    shoyer committed May 19, 2014
    Configuration menu
    Copy the full SHA
    e9e1866 View commit details
    Browse the repository at this point in the history