Add unlim dims for h5netcdf #1637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shoyer
reviewed
Oct 17, 2017
| if unlimited_dims is not None: | ||
| warnings.warn('h5netcdf does not support unlimited dimensions, ' | ||
| 'got: %s.' % unlimited_dims) | ||
| unlimited_dims = None | ||
| self.set_necessary_dimensions(variable, unlimited_dims=unlimited_dims) |
There was a problem hiding this comment.
You will need to set dimensions to their current size explicitly with resize_dimension(). h5netcdf doesn't support automatic enlargement with assignment yet.
There was a problem hiding this comment.
Yes, that makes sense. I was wondering where that belonged.
jhamman
changed the title
shoyer
approved these changes
Oct 18, 2017
|
@shoyer - all tests are passing here. The resize issue required a small refactor of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master | flake8 --diffwhats-new.rstfor all changes andapi.rstfor new API(these tests will fail until conda-forge get's an updated version of h5netcdf)