Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move kwarg's output_sizes and meta to dask_gufunc_kwargs for in… #4391

Merged
merged 2 commits into from
Aug 30, 2020
Merged

move kwarg's output_sizes and meta to dask_gufunc_kwargs for in… #4391

merged 2 commits into from
Aug 30, 2020

Conversation

kmuehlbauer
Copy link
Contributor

@kmuehlbauer kmuehlbauer commented Aug 30, 2020 •
edited
Loading

…ternal use of apply_ufunc (follow-up to #4060, fixes #4385)

  • Closes warnings from internal use of apply_ufunc #4385
  • Tests added
  • Passes isort . && black . && mypy . && flake8
  • User visible changes (including notable bug fixes) are documented in whats-new.rst
  • New functions/methods are listed in api.rst

@kmuehlbauer
Copy link
Contributor Author

@mathause @dcherian Seems it was really simple. I've fixed the internal behaviour for output_sizes and meta kwargs and added a reference to this pull request to whats-new.rst (internal changes part).

mathause
mathause approved these changes Aug 30, 2020
View reviewed changes
Copy link
Collaborator

@mathause mathause left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as far as I can see the warnings are gone. Thanks.

@dcherian
Copy link
Contributor

LGTM too. Thanks @kmuehlbauer

@dcherian dcherian merged commit ac38d19 into pydata:master Aug 30, 2020
@jhamman jhamman mentioned this pull request Nov 9, 2020
Closed
@kmuehlbauer kmuehlbauer deleted the fix-4385 branch May 25, 2023 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathause mathause mathause approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

warnings from internal use of apply_ufunc
3 participants
@kmuehlbauer @dcherian @mathause