Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dictionary unpacking when using .loc to avoid collision with .sel parameters #4695

Merged
merged 5 commits into from
Dec 16, 2020
Merged

Remove dictionary unpacking when using .loc to avoid collision with .sel parameters #4695

merged 5 commits into from
Dec 16, 2020

Conversation

andersy005
Copy link
Member

@andersy005 andersy005 commented Dec 15, 2020 •
edited
Loading

@max-sixty
Copy link
Collaborator

Great, I think this is the right approach.

Testing for some of these things would be good too, if possible :)

@andersy005
Copy link
Member Author

Testing for some of these things would be good too, if possible :)

👍🏽 This has been taken care of.

max-sixty
max-sixty approved these changes Dec 15, 2020
View reviewed changes
Copy link
Collaborator

@max-sixty max-sixty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks!

dcherian
dcherian approved these changes Dec 16, 2020
View reviewed changes
Copy link
Contributor

@dcherian dcherian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @andersy005 . Please go ahead and merge :)

@andersy005 andersy005 merged commit 19ebec5 into pydata:master Dec 16, 2020
@andersy005 andersy005 deleted the bugfix/loc-method-dim-name-corrision branch December 16, 2020 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcherian dcherian dcherian approved these changes

@max-sixty max-sixty max-sixty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Naming a dimension "method" throws error when calling ".loc"
3 participants
@andersy005 @max-sixty @dcherian