Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic validation of your citation metadata #6252

Closed
wants to merge 1 commit into from

Conversation

abelsiqueira
Copy link
Contributor

Hello!

We noticed that your repository is using the Citation File Format to store citation metadata in CITATION.cff. This Pull Request automates validation of that file using the cffconvert GitHub Action. That way, it's a little bit easier to be robust against future changes to the CITATION.cff file.

BTW it's perfectly fine if you don't feel like accepting this Pull Request for whatever reason -- we just thought it might be helpful is all.

We found your repository using a partially automated workflow; if you have any questions about that, feel free to create an issue over at https://github.com/cffbots/filtering/issues/

On behalf of the cffbots team,
@abelsiqueira / @fdiblen / @jspaaks

@max-sixty
Copy link
Collaborator

Have you considered making a pre-commit hook? That's our approach for consolidating these sorts of checks, to avoid a sprawl of checks, and to ensure they can be run locally.

@abelsiqueira
Copy link
Contributor Author

It is also possible to validate with a pre-commit hook, although I don't have much experience with it. I think something like

  - repo: https://github.com/citation-file-format/cff-converter-python
    rev: ebf0b5e44d67f8beaa1cd13a0d0393ea04c6058d
    hooks:
    - id: validate-cff

@jspaaks
Copy link

jspaaks commented Apr 19, 2022

Hi @max-sixty, thanks for the suggestion. I wasn't familiar with precommit hooks before, but recently @zmoon submitted a PR to add it to cffconvert (https://github.com/citation-file-format/cff-converter-python/blob/ebf0b5e44d67f8beaa1cd13a0d0393ea04c6058d/.pre-commit-hooks.yaml). It will be part of the next release.

@max-sixty
Copy link
Collaborator

Great! We would def take a PR to add that if you're up for modifying this.

Either way, thanks for contributing your tool to the community.

@abelsiqueira
Copy link
Contributor Author

Following our discussion, I have created #6658.

@dcherian
Copy link
Contributor

dcherian commented Jun 2, 2022

Thanks!

@dcherian dcherian closed this Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants