Fix FacetGrid.set_titles #6839

[lopezvoliver]

• Closes FacetGrid.set_title formatting keyword arguments fail when plot uses col and row #6839
• User visible changes (including notable bug fixes) are documented in whats-new.rst

Added handle.update(kwargs) after handle.set_text(title) so that the title properties sent using keyword arguments are also updated.

[dcherian]

Wonderful. Thanks @lopezvoliver !

Can you add a test in a new function around here (some docs here):

xarray/xarray/tests/test_plot.py

Line 2264 in 3f7cc2d

def test_default_labels(self):

I think it would look like

1. Create a facetgrid (see the existing tests for how to do that)
2. Make the titles bold.
3. Check that the title for a axis is acutally bold. You can use the axes handles in FacetGrid.axes to do this.

[lopezvoliver]

Hi @dcherian , thanks for the feedback.

Other than the test, I also had to add a new function property_in_axes_text that performs the check only on the specified label.

I hope this is what was expected.

Cheers

[dcherian]

👏🏾

[dcherian]

Thanks @lopezvoliver very nice fix. I see this is your first contribution. welcome to xarray!

(this will get merged in a couple of days after others have a chance to take a look if they want)