Forbid invalid Coordinates object #8884
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomNicholas
commented
Mar 28, 2024
| @@ -564,7 +564,7 @@ def merge_coords( | |||
|
|
|||
| def assert_valid_explicit_coords( | |||
| variables: Mapping[Any, Any], | |||
| dims: Mapping[Any, int], | |||
| dims: Iterable[Any], | |||
There was a problem hiding this comment.
I changed this because the lengths are never used, and renamed dims->sizes in a few places to avoid this confusion.
4 tasks
max-sixty
approved these changes
Mar 28, 2024
|
Alternatively we might want to drop |
Merged
4 tasks
|
Oh! Well that's cool. Closing in favour of #8886 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User visible changes (including notable bug fixes) are documented inwhats-new.rstNew functions/methods are listed inapi.rst