Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multidimensional variable with same name as dim when constructing dataset via coords #8886

Merged
merged 4 commits into from
Mar 28, 2024

Conversation

TomNicholas
Copy link
Contributor

@TomNicholas TomNicholas commented Mar 28, 2024

Supercedes #8884 as a way to close #8883, in light of me having learnt that this is now allowed! #8883 (comment). So this is really a follow-up to #7989.

@benbovy
Copy link
Member

benbovy commented Mar 28, 2024

Look like it will be enough to just remove the failing test!

@TomNicholas TomNicholas added the plan to merge Final call for comments label Mar 28, 2024
@dcherian
Copy link
Contributor

nice find!

@TomNicholas TomNicholas enabled auto-merge (squash) March 28, 2024 16:20
@TomNicholas TomNicholas merged commit 2120808 into pydata:main Mar 28, 2024
28 of 32 checks passed
@TomNicholas TomNicholas deleted the allow-nd-var-coords branch March 28, 2024 17:07
dcherian added a commit to dcherian/xarray that referenced this pull request Apr 2, 2024
* main: (26 commits)
  [pre-commit.ci] pre-commit autoupdate (pydata#8900)
  Bump the actions group with 1 update (pydata#8896)
  New empty whatsnew entry (pydata#8899)
  Update reference to 'Weighted quantile estimators' (pydata#8898)
  2024.03.0: Add whats-new (pydata#8891)
  Add typing to test_groupby.py (pydata#8890)
  Avoid in-place multiplication of a large value to an array with small integer dtype (pydata#8867)
  Check for aligned chunks when writing to existing variables (pydata#8459)
  Add dt.date to plottable types (pydata#8873)
  Optimize writes to existing Zarr stores. (pydata#8875)
  Allow multidimensional variable with same name as dim when constructing dataset via coords (pydata#8886)
  Don't allow overwriting indexes with region writes (pydata#8877)
  Migrate datatree.py module into xarray.core. (pydata#8789)
  warn and return bytes undecoded in case of UnicodeDecodeError in h5netcdf-backend (pydata#8874)
  groupby: Dispatch quantile to flox. (pydata#8720)
  Opt out of auto creating index variables (pydata#8711)
  Update docs on view / copies (pydata#8744)
  Handle .oindex and .vindex for the PandasMultiIndexingAdapter and PandasIndexingAdapter (pydata#8869)
  numpy 2.0 copy-keyword and trapz vs trapezoid (pydata#8865)
  upstream-dev CI: Fix interp and cumtrapz (pydata#8861)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plan to merge Final call for comments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Coordinates object permits invalid state
3 participants