You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I've encountered this issue while trying to write a solution to #1087.
I'm trying to add a past private tag to a dataset that had all his private tags removed with remove_private_tags. It leads to a single element update - just the private tag data. No private creator element is added. Also, the private tag is updated on the second free block rather than the first - that's supposed to be free after remove_private_tags.
It seems the dataset preserves some information on past private creators blocks even after remove_private_tags.
I expect that a private creator element would be (re-)created if I'm trying to add a private tag, and that it would created on the first available place in the private group.
* Invalidate private blocks on deleting private creator
- try to minimize performance impact by removing all private blocks
and checking for existing private blocks first
- fixes#1097
* Add support for non-contiguous private blocks
I've encountered this issue while trying to write a solution to #1087.
I'm trying to add a past private tag to a dataset that had all his private tags removed with remove_private_tags. It leads to a single element update - just the private tag data. No private creator element is added. Also, the private tag is updated on the second free block rather than the first - that's supposed to be free after remove_private_tags.
It seems the dataset preserves some information on past private creators blocks even after remove_private_tags.
I expect that a private creator element would be (re-)created if I'm trying to add a private tag, and that it would created on the first available place in the private group.
Reproducing code:
Output:
Aa far as I understand, output should be:
My environment (Running with docker from PyCharm):
Linux-4.15.0-74-generic-x86_64-with-debian-buster-sid
Python 3.6.9 |Anaconda, Inc.| (default, Jul 30 2019, 19:07:31)
[GCC 7.3.0]
pydicom 2.0.0.dev
The text was updated successfully, but these errors were encountered: