Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dicomdir should warn if not explicit VR little endian #848

Closed
darcymason opened this issue May 17, 2019 · 0 comments · Fixed by #980
Closed

Dicomdir should warn if not explicit VR little endian #848

darcymason opened this issue May 17, 2019 · 0 comments · Fixed by #980
Labels
enhancement
Milestone
v1.4

Comments

@darcymason
Copy link
Member

See discussion in #805. Pydicom default is implicit VR, but dicom standard requires explicit.

Should at least throw a warning, perhaps deprecate this for long future change to the correct default.
@darcymason darcymason added this to the v1.4 milestone May 27, 2019
@mrbean-bremen mrbean-bremen mentioned this issue Nov 26, 2019
Closed
25 tasks
mrbean-bremen added a commit to mrbean-bremen/pydicom that referenced this issue Nov 29, 2019
@mrbean-bremen
Added warning if a DICOMDIR has an unexpected transfer syntax
634db8b 
 - if config.enforce_valid_values is set, an exception is raised
 - closes pydicom#848
mrbean-bremen added a commit to mrbean-bremen/pydicom that referenced this issue Nov 29, 2019
@mrbean-bremen
Added warning if a DICOMDIR has an unexpected transfer syntax
6473d56 
 - if config.enforce_valid_values is set, an exception is raised
 - closes pydicom#848
@mrbean-bremen mrbean-bremen mentioned this issue Nov 29, 2019
Merged
6 tasks
darcymason pushed a commit that referenced this issue Nov 30, 2019
@mrbean-bremen @darcymason
Added warning if a DICOMDIR has an unexpected transfer syntax (#980)
0890fe9 
*  Added warning if a DICOMDIR has an unexpected transfer syntax

 - if config.enforce_valid_values is set, an exception is raised
 - closes #848
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
v1.4
Development

Successfully merging a pull request may close this issue.

[MRG] Added warning if a DICOMDIR has an unexpected transfer syntax mrbean-bremen/pydicom
2 participants
@darcymason @mrbean-bremen