Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: search term moved to q #92

Merged
merged 1 commit into from
Sep 27, 2023
Merged

fix: search term moved to q #92

merged 1 commit into from
Sep 27, 2023

Conversation

weber-s
Copy link

@weber-s weber-s commented Sep 27, 2023

Summary of changes

Discourse search api use q and not term https://docs.discourse.org/#tag/Search/operation/search .

I do not know for how long it is broken or if it is only for recent discourse version, but this is possible breaking change for pydiscourse.

Checklist

  • Changes represent a discrete update
  • Commit messages are meaningful and descriptive
  • Changeset does not include any extraneous changes unrelated to the discrete change

@bennylope bennylope merged commit 53be265 into pydiscourse:master Sep 27, 2023
5 checks passed
@bennylope
Copy link
Collaborator

Yes, probably a possibility of a breaking change if someone is passing the search term as a keyword argument. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants