Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add feature to specify task parameters in doit.cfg (issue #283) #322

Closed
wants to merge 11 commits into from
Closed

Add feature to specify task parameters in doit.cfg (issue #283) #322

wants to merge 11 commits into from

Commits on Aug 12, 2019

  1. Add feature to specify task parameters in doit.cfg (issue pydoit#238)

    @rbdixon
    rbdixon committed Aug 12, 2019
    Configuration menu
    Copy the full SHA
    b828326 View commit details
    Browse the repository at this point in the history

  2. First pass at implementing recommendations.

    @rbdixon
    rbdixon committed Aug 12, 2019
    Configuration menu
    Copy the full SHA
    21dad96 View commit details
    Browse the repository at this point in the history

  3. Move cfg_value loading so it works for run and auto commands

    @rbdixon
    rbdixon committed Aug 12, 2019
    Configuration menu
    Copy the full SHA
    61ae094 View commit details
    Browse the repository at this point in the history

  4. Refactor how task command line arguments are parsed. 

    All command line parsing should be in Task now.
    @rbdixon
    rbdixon committed Aug 12, 2019
    Configuration menu
    Copy the full SHA
    e60e5b1 View commit details
    Browse the repository at this point in the history

  5. Test for Task()

    @rbdixon
    rbdixon committed Aug 12, 2019
    Configuration menu
    Copy the full SHA
    3ed80a6 View commit details
    Browse the repository at this point in the history

  6. Add test to confirm loader sets task args from config.

    @rbdixon
    rbdixon committed Aug 12, 2019
    Configuration menu
    Copy the full SHA
    c8ab530 View commit details
    Browse the repository at this point in the history

  7. Fix error where a loaded config file was required.

    @rbdixon
    rbdixon committed Aug 12, 2019
    Configuration menu
    Copy the full SHA
    c94a613 View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2019

  1. Add test doc string

    @rbdixon
    rbdixon committed Aug 13, 2019
    Configuration menu
    Copy the full SHA
    d3cabbb View commit details
    Browse the repository at this point in the history

  2. Only replace task options with default values when specified as argum… 

    …ents.
    @rbdixon
    rbdixon committed Aug 13, 2019
    Configuration menu
    Copy the full SHA
    e3df160 View commit details
    Browse the repository at this point in the history

  3. Modify test_control.py to use a fixture to create sample tasks. 

    Task.init_options() will only initialize options once. The tests
were written so that each test reused the same task instances and
therefore the tests failed because the expected task option defaults
were not applied. The fix is to use a fixture to redefine the tasks
each time.

The only-once semantics of Task.init_options() dates back four years
and the commit indicates this was a performance enhancement.
    @rbdixon
    rbdixon committed Aug 13, 2019
    Configuration menu
    Copy the full SHA
    ad254ea View commit details
    Browse the repository at this point in the history

  4. docs

    @rbdixon
    rbdixon committed Aug 13, 2019
    Configuration menu
    Copy the full SHA
    f99dce1 View commit details
    Browse the repository at this point in the history