Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add codecov, tweak some spelling #384

Merged
merged 1 commit into from
Mar 14, 2021
Merged

Conversation

bollwyvl
Copy link
Contributor

A follow-up to #379 (review), this uploads coverage to codecov, which is slightly simpler to set up, and doesn't require a secret token.

Also fixes a few spelling issues, just so we can see all the ✔️ .

@bollwyvl
Copy link
Contributor Author

I think to get the report to show up in the issue, one button must be pushed, once, in the codecov app.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.729% when pulling 9ea3645 on bollwyvl:add-codecov into 0aa4cc5 on pydoit:master.

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@0aa4cc5). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #384   +/-   ##
=========================================
  Coverage          ?   99.72%           
=========================================
  Files             ?       65           
  Lines             ?     8828           
  Branches          ?        0           
=========================================
  Hits              ?     8804           
  Misses            ?       24           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0aa4cc5...9ea3645. Read the comment docs.

@bollwyvl
Copy link
Contributor Author

Adding the codecov badge does require a (non-secret) token... the markdown/rst can be copied from the settings page on codecov.

@bollwyvl bollwyvl mentioned this pull request Mar 14, 2021
@schettino72
Copy link
Member

  .. image:: https://codecov.io/gh/pydoit/doit/branch/master/graph/badge.svg?token=wxKa1h11zn
  :target: https://codecov.io/gh/pydoit/doit

@schettino72
Copy link
Member

When I click on "continue to full report" [1], it says the page is missing.

[1] https://app.codecov.io/gh/pydoit/doit/compare/384

@bollwyvl
Copy link
Contributor Author

Yeah, once some reports hit master, it starts working more.

@schettino72 schettino72 merged commit 43f28e6 into pydoit:master Mar 14, 2021
@bollwyvl
Copy link
Contributor Author

oh, merged! welp, added some badges on my push, feel free to steal!

@schettino72
Copy link
Member

merged. thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants