Add github actions #379
Add github actions #379
Conversation
bollwyvl
commented
Dec 8, 2020
bollwyvl
commented
- fixes Add GitHub Actions? #378
| - if: ${{ matrix.os == 'ubuntu' && matrix.python-version == '3.8' }} | ||
| run: | | ||
| doit coverage | ||
| coveralls || echo "TODO: remove when run on a repo that is set up" |
There was a problem hiding this comment.
What this means? "which kind of repo setup"?
There was a problem hiding this comment.
I hadn't set up codecov in a while, since the bad old days when a token was needed. I assume it's just working now?
There was a problem hiding this comment.
Ok understood. No, it is not working:
INFO:coveralls:422
INFO:coveralls:{"message":"Couldn't find a repository matching this job.","error":true}
TODO: remove when run on a repo that is set up
I dont understand this error message. It seems to work well on travis... Any idea why ?
There was a problem hiding this comment.
Yeah, there's probably a token or something. And looking at it, of course, it's coveralls. It looks it does need a token in secrets, which I don't like to bother with until i absolutely must.
I have been using codecov recently, which doesn't require a secret for public repos, and only generates one PR comment, which it updates, which I find more convenient... will do a follow-up PR with a demo.
There was a problem hiding this comment.
PR up #384 with lots of ✔️
