Add support for paths rooted beyond / #182
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is possible to put the ElasticSearch api behind a proxy with a different root path than /. Old code assumed / was used everywhere. Update things to accept a longer path to support ElasticSearch servers proxied in this manner. Note that because we rely on elasticsearch lib's Transport class we can't currently allow different paths for each host. You are still limited to having all hosts proxied behind the same path.
cboylan
force-pushed
the
support-different-root
branch
from
550c962
to
e25c507
Compare
|
The test suite seems to expect a running ElasticSearch server which isn't present in Travis? Any guidance on how I can get this working is appreciated. |
cboylan
added a commit
to openstack-infra/elastic-recheck
that referenced
this pull request
Nov 10, 2015
This reverts commit 87453fe. Reverting because newer pyelasticsearch does not support API roots other than / which breaks against our root of /elasticsearch. I have pushed pyelasticsearch/pyelasticsearch#182 upstream to fix so maybe we can upgrade once that gets in and is released. Change-Id: I4ba78fac924bf6d2ec8ccda1af6970577c74e6ec
cboylan
added a commit
to openstack/openstack
that referenced
this pull request
Nov 10, 2015
Project: openstack-infra/elastic-recheck b9946fded52a1cdd88e275415cf0f83a8bdfc870 Revert "Update pyelasticsearch to >=1.4" This reverts commit 87453fe17bb3051c46058d7b1972fb320e38e54f. Reverting because newer pyelasticsearch does not support API roots other than / which breaks against our root of /elasticsearch. I have pushed pyelasticsearch/pyelasticsearch#182 upstream to fix so maybe we can upgrade once that gets in and is released. Change-Id: I4ba78fac924bf6d2ec8ccda1af6970577c74e6ec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible to put the ElasticSearch api behind a proxy with a
different root path than /. Old code assumed / was used everywhere.
Update things to accept a longer path to support ElasticSearch servers
proxied in this manner.
Note that because we rely on elasticsearch lib's Transport class we
can't currently allow different paths for each host. You are still
limited to having all hosts proxied behind the same path.