Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pyenv-latest to ignore virtualenvs #2608

Merged
merged 2 commits into from
Feb 2, 2023

Conversation

native-api
Copy link
Member

Make sure you have checked all steps below.

Prerequisite

  • Please consider implementing the feature as a hook script or plugin as a first step.
    • pyenv has some powerful support for plugins and hook scripts. Please refer to Authoring plugins for details and try to implement it as a plugin if possible.
  • Please consider contributing the patch upstream to rbenv, since we have borrowed most of the code from that project.
    • We occasionally import the changes from rbenv. In general, you can expect changes made in rbenv will be imported to pyenv too, eventually.
    • Generally speaking, we prefer not to make changes in the core in order to keep compatibility with rbenv.
  • My PR addresses the following pyenv issue (if any)

Description

  • Here are some details about my PR

When there are virtualenvs, pyenv-latest erroneously searches them for prefix resolution, too:

$ echo $PYENV_VERSION
pypy2.7-7
$ pyenv versions
  system
  3.10.9
  3.10.9/envs/venv
  3.11-dev
  pypy2.7-7.3.11
* pypy2.7-7.3.11/envs/venvpypy (set by PYENV_VERSION environment variable)
  venv
  venvpypy

Tests

  • My PR adds the following unit tests (if any)

Test for ignoring specific entry types

@native-api native-api merged commit 368e04f into pyenv:master Feb 2, 2023
@native-api native-api deleted the pyenv_exclude_virtualenvs branch February 2, 2023 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant