Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore virtualenvs in `pyenv latest' in a clean way #2610

Merged
merged 3 commits into from
Feb 2, 2023

Conversation

native-api
Copy link
Member

Make sure you have checked all steps below.

Prerequisite

  • Please consider implementing the feature as a hook script or plugin as a first step.
    • pyenv has some powerful support for plugins and hook scripts. Please refer to Authoring plugins for details and try to implement it as a plugin if possible.
  • Please consider contributing the patch upstream to rbenv, since we have borrowed most of the code from that project.
    • We occasionally import the changes from rbenv. In general, you can expect changes made in rbenv will be imported to pyenv too, eventually.
    • Generally speaking, we prefer not to make changes in the core in order to keep compatibility with rbenv.
  • My PR addresses the following pyenv issue (if any)

Description

  • Here are some details about my PR

The core reason why #2608 happened is because pyenv-versions prints */envs/* in addition to the raw versions/ contents. So the clean way to fix it is to make it not do so in the first place.

Tests

  • My PR adds the following unit tests (if any)
    Test for the added pyenv-versions option

@native-api native-api merged commit c8c324a into pyenv:master Feb 2, 2023
@native-api native-api deleted the version_skip_envs branch February 2, 2023 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant