Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow for latest versions of packaging #25

Closed
wants to merge 1 commit into from
Closed

allow for latest versions of packaging #25

wants to merge 1 commit into from

Conversation

jamesturk
Copy link

Right now trying to use django-magiclink alongside current versions of libraries like black results in an error like:

Using python3 (3.12.0)

Updating dependencies
Resolving dependencies... (0.1s)

Because django-magiclink (1.3.0) @ django-magiclink depends on packaging (>=20.9,<22.0)
 and black (23.9.1) depends on packaging (>=22.0), django-magiclink (1.3.0) @ django-magiclink is incompatible with black (23.9.1).
And because no versions of black match >23.9.1,<24.0.0, django-magiclink (1.3.0) @ django-magiclink is incompatible with black (>=23.9.1,<24.0.0).

This requirement can be safely relaxed it seems, this will work until a 2024 version is released.

@simkimsia
Copy link

Ah i didn't realize there was an existing PR for this when I wrote #27 and #28

In any case, I have released a fork and patch with instructions on how to pip install as well

at https://github.com/simkimsia/django-magiclink/releases/tag/packaging-upgraded-1.3.0

@jamesturk jamesturk closed this by deleting the head repository Jan 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants