Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pyproject.toml to allow packaging < v24 #28

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

simkimsia
Copy link

fixed #27

@Mogost
Copy link

Mogost commented Feb 9, 2024

@pyepye Is there any chance to have this released?

Mogost
Mogost approved these changes Feb 9, 2024
pyproject.toml Show resolved Hide resolved
Copy link

@Mogost Mogost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Lock file was not updated.

@Mogost Mogost mentioned this pull request Feb 9, 2024
fixed pyepye#27 27

Update poetry.lock

Signed-off-by: KimSia, Sim <245021+simkimsia@users.noreply.github.com>
@simkimsia
Copy link
Author

simkimsia commented Feb 10, 2024

The Lock file was not updated.

I did a force push with commit 264db37 to include the Lock file updates as mentioned in #28 (review) by @Mogost

@Mogost
Copy link

Mogost commented Feb 10, 2024

The Lock file was not updated.

I did a force push with commit 264db37 to include the Lock file updates as mentioned in #28 (review) by @Mogost

#30 actually I think this PR is better. And resolves the same problem.

@simkimsia
Copy link
Author

#30 actually I think this PR is better. And resolves the same problem.

Happy to adopt whatever @pyepye eventually merges with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

can we bump packaging to be above v22 given that it's now v23?
2 participants