Media Endpoint Role Based Access Control

[masrayie]

Hello, I'm using Role Based Access Control

But how I can use this function to media endpoint.
Because it only works when I set the role in ALLOWED_READ_ROLES, it doesn't work if only set on ALLOWED_ITEM_READ_ROLES, which is security risk.

I'm trying to modify the auth.py file and I add some logic for media endpoint like this below in requires_auth function:
elif endpoint_class == "media":
resource_name = resource = None
public = app.config["PUBLIC_METHODS"] + ["OPTIONS"]
roles = list(app.config["ALLOWED_ROLES"])
if request.method in ["GET", "OPTIONS"]:
roles += app.config["ALLOWED_READ_ROLES_MEDIA"]
auth = app.auth
And it works well, is it okay ?

Thank you.

[stale]

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.