Add support to the bitwise query operator. #1055
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bitwise query operator e.g., `$bitsAllClear` can be useful for query over number. However, `eve` doesn't support it yet. This PR add the supports of bitwise query operator.
Amedeo91
reviewed
Aug 30, 2017
|
@Amedeo91 sure, give me two days. |
|
@Amedeo91 do we have an example on how to write a test. I checked the tests for |
|
Maybe add something in the test/method/get.py |
|
@Amedeo91 after reading more on the code, I feel writing an effective test on those bitwise operations may not be trivial work. The current code doesn't consider testing for those operators, e.g., $ge. |
|
I see. Maybe let us check with @nicolaiarocci if it might be wiser to track a milestone to add a more extensive test coverage for this operators. |
|
I will add the test myself. |
nicolaiarocci
added a commit
that referenced
this pull request
Nov 7, 2017
|
Test added, rebased and merged (2d2ad29). Thanks. |
lexhung
added a commit
to lexhung/eve
that referenced
this pull request
Dec 10, 2017
* 'master' of https://github.com/pyeve/eve: (23 commits) Remove twitter and add StackOverflow from support options Add Codemotion Rome 2017 to sessions list Add sphinxcontrib-embedly to dev-requirements.txt v0.7.5 release date Moritz Schneider Changelog for pyeve#1091 Bump version to 0.7.5 Fix sanitization of nested queries. Fix: serialization failure with schema registries. Remove flake8 from travis matrix flake8 runs on CI with py35 Improve robustness on ObjectId validation Re-add flake8 to test runs Make sure non-dict schema definitions are correctly handled New: media endpoint secured by default auth class. Fix test which was broken by previous PR Qiang Zhang Changelog update for pyeve#1055 Add test for bitwise query operator feature. Add support to the bitwise query operator. ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bitwise query operator e.g.,
$bitsAllClearcan be useful for query over number. However,evedoesn't support it yet. This PR add the supports of bitwise query operator.