DjangoBookWriter does not support batch_size

[readflybird]

In class DjangoBookWriter, the open_content() method, the parameters keywords are ignored and thus there is no way we can pass in the batch_size. Besides, the create_sheet() method does not take care of batch_size, neither. Therefore there is no way we can do a batch insert through DjangoModelWriter.

[chfw]

It is true that 'batch_size' was not passed on and 'batch_size' controls the number of records being inserted at once. If not mentioned, default batch_size 999 is used. However, it won't block batch insertion.

Please check for database error such as integrity error during bulk import. Once there is any exception, it will default to 'snail' alike insertion - one record at a time, skipping offending ones.

[readflybird]

Thanks for the quick fix. Is there any plan that to merge this change into a release branch?

[chfw]

by default, I would release it with v0.3.0, which should be released by the end of this year. Can you wait for it? Otherwise, I can do a quick release as v0.2.6.

[chfw]

released in v0.2.6 via pypi

[readflybird]

Thanks a lot for the response! I have tried out the new version and it works great!