Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some more updates for python 3 language changes, tidyups #276

Merged
merged 16 commits into from
Aug 12, 2024

Conversation

marksmayo
Copy link
Contributor

@marksmayo marksmayo commented Jul 18, 2023

With your PR, here is a check list:

  • [NA ] Has test cases written?
  • [ Y] Has all code lines tested?
  • [N - doesn't run on windows ] Has make format been run?
  • Please update CHANGELOG.yml(not CHANGELOG.rst)
  • [NA ] Has fair amount of documentation if your change is complex
  • [ Y] Agree on NEW BSD License for your contribution

@codecov-commenter
Copy link

codecov-commenter commented Jul 18, 2023

Codecov Report

Merging #276 (a6e916f) into dev (ee0722a) will decrease coverage by 0.01%.
The diff coverage is 97.01%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##              dev     #276      +/-   ##
==========================================
- Coverage   98.42%   98.42%   -0.01%     
==========================================
  Files          98       98              
  Lines        6714     6711       -3     
==========================================
- Hits         6608     6605       -3     
  Misses        106      106              
Impacted Files Coverage Δ
pyexcel/__init__.py 100.00% <ø> (ø)
pyexcel/docstrings/__init__.py 100.00% <ø> (ø)
pyexcel/docstrings/keywords.py 100.00% <ø> (ø)
pyexcel/plugins/parsers/__init__.py 100.00% <ø> (ø)
pyexcel/plugins/parsers/django.py 93.75% <ø> (ø)
pyexcel/plugins/parsers/excel.py 100.00% <ø> (ø)
pyexcel/plugins/parsers/sqlalchemy.py 93.75% <ø> (ø)
pyexcel/plugins/renderers/__init__.py 100.00% <ø> (ø)
pyexcel/plugins/sources/db_sources.py 94.36% <ø> (ø)
pyexcel/plugins/sources/django.py 100.00% <ø> (ø)
... and 54 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@marksmayo
Copy link
Contributor Author

Hit my limit here. Not sure how to fix last issues in win.

@chfw chfw merged commit d773908 into pyexcel:dev Aug 12, 2024
6 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants