-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unwanted minor tick label for log plots #450
Conversation
So far I've only added this to the
|
Thanks for checking, I think it resolves the issue. I did not see any effect on linear axes. Applying it only to log. frequency axis might be the cleaner solution as it would maintain as much Matplotlib default behavior as possible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just minor things.
I'd also agree to not use this for linearly scaled axes.
We should not close #71 though, or create a new issue, since this only fixes part of the issue. The other problem is that one may end up with a very low number (or on extreme cases none) of major ticks when zooming in on the frequency axis.
pyfar/plot/_line.py
Outdated
from matplotlib.ticker import ( | ||
NullFormatter | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from matplotlib.ticker import ( | |
NullFormatter | |
) | |
from matplotlib.ticker import NullFormatter |
pyfar/plot/_two_d.py
Outdated
from matplotlib.ticker import ( | ||
NullFormatter | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from matplotlib.ticker import ( | |
NullFormatter | |
) | |
from matplotlib.ticker import NullFormatter |
Agreed and opened a new issue with a more specific name #451 |
Just fixed the comments from @mberz. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for implementing!
Which issue(s) are closed by this pull request?
Closes #71
Changes proposed in this pull request: