Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove obsolete information from print Coordinates #549

Merged
merged 1 commit into from
Mar 12, 2024
Merged

Conversation

ahms5
Copy link
Member

@ahms5 ahms5 commented Feb 27, 2024

Changes proposed in this pull request:

change output from:

1D Coordinates object with 40 points of cshape (40,)
domain: cart, convention: right, unit: met
coordinates: x in meters, y in meters, z in meters
Does not contain sampling weights

to:

1D Coordinates object with 40 points of cshape (40,)
Does not contain sampling weights

@ahms5 ahms5 added bug For bugs not on the master branch coordinates v0.6.5 labels Feb 27, 2024
@ahms5 ahms5 requested review from f-brinkmann, pingelit, mberz and sikersten and removed request for f-brinkmann, pingelit and mberz February 27, 2024 09:49
Copy link
Member

@f-brinkmann f-brinkmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks clearner now. But I'm not sure if we consider it a bug and merge into main or merge into dev for later release.

@sikersten
Copy link
Member

Thanks, this looks clearner now. But I'm not sure if we consider it a bug and merge into main or merge into dev for later release.

+1 for bugfix in develop instead of hotfix in main

@pingelit
Copy link
Contributor

pingelit commented Mar 4, 2024

Yes, I also think this is a bugfix.

@ahms5
Copy link
Member Author

ahms5 commented Mar 4, 2024

a bugfix is a bug on development and will be fixed in a patch release, a hotfix is a bug on main and should be fixes by a patch release. (even it's not that critical).
Every version, in this case 0.6.x, in itself should be as free from bugs as possible, so I would like to handle it as a hotfix.

@mberz
Copy link
Member

mberz commented Mar 12, 2024

Thanks for implementing, I'm all for more compact reprs
Since everyone accepted, I'll merge into main.

@mberz mberz merged commit 76ed23a into main Mar 12, 2024
12 checks passed
@mberz mberz deleted the fix/print_coords branch March 12, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug For bugs not on the master branch coordinates v0.6.5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants