numba: Add support for the projection operator #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-wieser
commented
Jun 19, 2020
Comment on lines
-860
to
-876
| @numba.njit | ||
| def _project(mv, grade): | ||
| """ fast grade projection """ | ||
| output = np.zeros_like(mv.value) | ||
| if grade == 0: | ||
| output[0] = mv.value[0] | ||
| elif grade == 1: | ||
| output[1:6] = mv.value[1:6] | ||
| elif grade == 2: | ||
| output[6:16] = mv.value[6:16] | ||
| elif grade == 3: | ||
| output[16:26] = mv.value[16:26] | ||
| elif grade == 4: | ||
| output[26:31] = mv.value[26:31] | ||
| elif grade == 5: | ||
| output[31] = mv.value[31] | ||
| return mv.layout.MultiVector(output) |
There was a problem hiding this comment.
This doesn't actually seem to be any faster than my approach.
|
This pull request introduces 3 alerts when merging c77a631 into bb0e2d1 - view on LGTM.com new alerts:
|
Numba does not make it easy to overload `__call__` at the moment. We should follow up with numba to see if they can make it easier in future.
|
This pull request introduces 2 alerts when merging 581a135 into bb0e2d1 - view on LGTM.com new alerts:
|
|
3.8 CI is the usual, LGTM complaints are github/codeql#3741 (invalid) and don't-care. |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Numba does not make it easy to overload
__call__at the moment.We should follow up with numba to see if they can make it easier in future.
xref numba/numba#5885.