Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 2D PGA (Cl(2,0,1)) #365

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add 2D PGA (Cl(2,0,1)) #365

wants to merge 2 commits into from

Conversation

kliment
Copy link

@kliment kliment commented Oct 4, 2020

Adds a 2D version of the projective GA using Cl(2,0,1) - this is wonderful for working with lines, points, areas, angles and distances in the plane.

@lgtm-com
Copy link

lgtm-com bot commented Oct 4, 2020

This pull request introduces 1 alert when merging 7b163ae into a1b1ba3 - view on LGTM.com

new alerts:

  • 1 for Modification of dictionary returned by locals()

@eric-wieser
Copy link
Member

@kliment
Copy link
Author

kliment commented Oct 5, 2020

Done

@lgtm-com
Copy link

lgtm-com bot commented Oct 5, 2020

This pull request introduces 1 alert when merging e526291 into a1b1ba3 - view on LGTM.com

new alerts:

  • 1 for Modification of dictionary returned by locals()

@kliment
Copy link
Author

kliment commented Feb 17, 2021

Just checking, do you need anything more from my end to merge this?

@arsenovic
Copy link
Member

@eric-wieser what do you think? not sure about the tests, but seems like a pretty simple addition?

@eric-wieser
Copy link
Member

There was a discussion on our slack about what to name the algebra, we should check if that came to a conclusion before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants