Deprecate Mlt.extact_basis_indexes [sic] #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-wieser
force-pushed
the
deprecate-extact_basis_indexes
branch
from
c084f79
to
1bb8149
Compare
eric-wieser
force-pushed
the
deprecate-extact_basis_indexes
branch
from
1bb8149
to
a0945bb
Compare
This function has a typo in the name, and is a remnant of a workaround for old and dangerous printer behavior. At any rate, it is unnecessary as we already compute this value elsewhere.
eric-wieser
force-pushed
the
deprecate-extact_basis_indexes
branch
from
a0945bb
to
fccc7e0
Compare
Codecov Report
@@ Coverage Diff @@
## master #338 +/- ##
==========================================
- Coverage 75.86% 75.84% -0.02%
==========================================
Files 16 16
Lines 4495 4484 -11
==========================================
- Hits 3410 3401 -9
+ Misses 1085 1083 -2
Continue to review full report at Codecov.
|
utensil
approved these changes
May 16, 2020
eric-wieser
added
the
has changelog entry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function has a typo in the name, and is a remnant of a workaround for old and dangerous printer behavior.
At any rate, it is unnecessary as we already compute this value elsewhere.
Depends on #136 and #337