Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine nargs == 1 with nargs < 1 #136

Merged
merged 1 commit into from May 15, 2020

Conversation

eric-wieser
Copy link
Member

@eric-wieser eric-wieser commented Dec 4, 2019

The rank = 1 code path is just a loop unrolling of the general code path. That's not useful, lets not do it.

Also replaces 0 with S(0), and makes nargs == 0 work for the heck of it by using the initial argument to reduce.

First commit is #337, let's get that in first before merging this, so we can see if the lines this touches are covered.

@codecov
Copy link

codecov bot commented Dec 4, 2019

Codecov Report

Merging #136 into master will decrease coverage by 0.01%.
The diff coverage is 87.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #136      +/-   ##
==========================================
- Coverage   75.50%   75.49%   -0.02%     
==========================================
  Files          15       15              
  Lines        4479     4472       -7     
==========================================
- Hits         3382     3376       -6     
+ Misses       1097     1096       -1     
Impacted Files Coverage Δ
galgebra/lt.py 57.61% <87.50%> (-0.35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3d01db...0c235a4. Read the comment docs.

@eric-wieser
Copy link
Member Author

eric-wieser commented Dec 4, 2019

The diff coverage is 0%.

Hmm, that's not reassuring. Probably best not to merge this until that code has some coverage.

@eric-wieser eric-wieser added the merge_postponed PRs that should not be merged until the code they affect has tests label Dec 8, 2019
@eric-wieser eric-wieser added the ✓ soft CI failure PRs which fail quality but not test CIs label Dec 16, 2019
The rank = 1 code path is just a loop unrolling of the general code path. That's not useful, lets not do it.

Also replaces 0 with S(0), and makes nargs == 0 work for the heck of it by using the initial argument to reduce.
@eric-wieser eric-wieser removed merge_postponed PRs that should not be merged until the code they affect has tests ✓ soft CI failure PRs which fail quality but not test CIs labels May 13, 2020
@eric-wieser eric-wieser marked this pull request as ready for review May 13, 2020 14:53
@eric-wieser eric-wieser requested a review from utensil May 13, 2020 14:53
@eric-wieser eric-wieser added the ✓ soft CI failure PRs which fail quality but not test CIs label May 13, 2020
@eric-wieser
Copy link
Member Author

Coverage drop is to be expected because this removes lines of code. Patch coverage is still high.

@utensil utensil merged commit ae597d4 into pygae:master May 15, 2020
Miscellaneous cleanup automation moved this from Low priority to Closed May 15, 2020
@eric-wieser eric-wieser deleted the remove-1-special-case branch May 15, 2020 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✓ soft CI failure PRs which fail quality but not test CIs
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants