Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mailmap to merge Alan's old usernames #162

Merged
merged 1 commit into from Dec 17, 2019
Merged

Conversation

eric-wieser
Copy link
Member

I've avoided putting any of his active email addresses here for spam reasons.

I've avoided putting any of his active email addresses here for spam reasons.
Comment on lines +8 to +9
# This file is up-to-date if the command git log --format="%aN <%aE>" | sort -u
# gives no duplicates.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This gives:

Alan Bromborsky <abrombo@users.noreply.github.com>
alex arsenovic <REDACTED1@gmail.com>
arsenovic <REDACTED1@gmail.com>
Eric Wieser <REDACTED2@gmail.com>
eric-wieser <REDACTED2@gmail.com>
hugo hadfield <REDACTED3@gmail.com>
Hugo Hadfield <REDACTED3@gmail.com>
hugohadfield <REDACTED3@gmail.com>
Sylvain Meunier <REDACTED4@gmail.com>
utensil <REDACTED5@gmail.com>
Utensil Song <REDACTED5@gmail.com>
Waldir Pimenta <REDACTED6@gmail.com>

Still duplicates, but the only way to fix them is to put your email address in a more visible place than before, which is something I should let people opt into individually.

@utensil
Copy link
Member

utensil commented Dec 17, 2019

Cool, I didn't know we can do this.

@codecov
Copy link

codecov bot commented Dec 17, 2019

Codecov Report

Merging #162 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #162   +/-   ##
=======================================
  Coverage   67.23%   67.23%           
=======================================
  Files           8        8           
  Lines        4740     4740           
=======================================
  Hits         3187     3187           
  Misses       1553     1553

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 932f3c1...69d424c. Read the comment docs.

@eric-wieser
Copy link
Member Author

It only works for local clients - github ignores this

@utensil utensil merged commit 0dd91d8 into pygae:master Dec 17, 2019
@utensil utensil added this to the 0.4.5 milestone Dec 18, 2019
@eric-wieser eric-wieser deleted the mailmap branch April 20, 2020 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants