More cleanups to Lt #460
Merged
More cleanups to Lt #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a lot easier to follow if we just handle `xreplace` manually. Note that as a consequence, `mv_dict` now contains the scalar. This doesn't affect behavior, and it's not clear that `mv_dict` is intended to be public anyway.
eric-wieser
added
component: docs
|
Failure is #441 |
These attributes did not contain correct values if the non-string constructor was used. This corrects the implementation, but also deprecates it because its not clear that it's useful anyway.
eric-wieser
force-pushed
the
tidy-lt
branch
from
94a0faf
to
8332473
Compare
utensil
approved these changes
Sep 24, 2020
utensil
added
the
state: needs changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes a deprecation of two properties that were probably intended to be private anyway,
Docs are at https://galgebra--460.org.readthedocs.build/en/460/generated/galgebra.lt.html#galgebra.lt.Lt