Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace SVGs of LaTeX to just LaTeX #503

Merged
merged 4 commits into from
Mar 30, 2024
Merged

Replace SVGs of LaTeX to just LaTeX #503

merged 4 commits into from
Mar 30, 2024

Conversation

utensil
Copy link
Member

@utensil utensil commented Mar 30, 2024

This should supersede #415

@utensil
Copy link
Member Author

utensil commented Mar 30, 2024

For light mode:

image image

For dark mode:

image image

@utensil
Copy link
Member Author

utensil commented Mar 30, 2024

The issue is that this doesn't work for the Sphinx doc yet:

image

Copy link

codecov bot commented Mar 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.77%. Comparing base (08cf8ca) to head (9c8facc).

❗ Current head 9c8facc differs from pull request most recent head ddf95fb. Consider uploading reports for the commit ddf95fb to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #503   +/-   ##
=======================================
  Coverage   77.77%   77.77%           
=======================================
  Files          17       17           
  Lines        4193     4193           
=======================================
  Hits         3261     3261           
  Misses        932      932           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@utensil
Copy link
Member Author

utensil commented Mar 30, 2024

Now we have a very interesting problem that Github doesn't accpet ^ in \texttt but mdinclude will display \^{} as is.

image

@utensil utensil merged commit e96f8d1 into master Mar 30, 2024
5 checks passed
@utensil utensil added this to the 0.5.1 milestone Mar 30, 2024
@utensil utensil added the state: needs changelog Needs a changelog entry before the next release. Remove this label when the changelog is done. label Mar 31, 2024
@utensil
Copy link
Member Author

utensil commented Mar 31, 2024

One improvement of using sphinx_mdinclude is the TOC

image

v.s.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state: needs changelog Needs a changelog entry before the next release. Remove this label when the changelog is done.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant