Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename kargs to args #55

Merged
merged 1 commit into from Nov 20, 2019

Conversation

@eric-wieser
Copy link
Contributor

eric-wieser commented Nov 19, 2019

The typical python function signature is f(*args, **kwargs) not f(*kargs, **kwargs).

The kw in kwargs stands for keyword, but the first k doesn't mean anything.

@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 19, 2019

Codecov Report

Merging #55 into master will not change coverage.
The diff coverage is 72.89%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #55   +/-   ##
=======================================
  Coverage   66.57%   66.57%           
=======================================
  Files           8        8           
  Lines        4906     4906           
=======================================
  Hits         3266     3266           
  Misses       1640     1640
Impacted Files Coverage Δ
galgebra/lt.py 43.09% <42.85%> (ø) ⬆️
galgebra/ga.py 74.32% <60.71%> (ø) ⬆️
galgebra/mv.py 61.61% <80.55%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f0210d...01a73af. Read the comment docs.

The typical python function signature is `f(*args, **kwargs)` not `f(*kargs, **kwargs)`.

The `kw` in `kwargs` stands for `keyword`, but the first `k` doesn't mean anything.
@eric-wieser eric-wieser requested a review from utensil Nov 20, 2019
@utensil

This comment has been minimized.

Copy link
Member

utensil commented Nov 20, 2019

LGTM. As long as the conflicts are solved, we're good to go!

@eric-wieser eric-wieser force-pushed the eric-wieser:rename-kargs branch from 1421c9c to 01a73af Nov 20, 2019
@eric-wieser eric-wieser merged commit 4d7f524 into pygae:master Nov 20, 2019
5 checks passed
5 checks passed
Travis CI - Pull Request Build Passed
Details
codebeat no reportable quality changes
Details
codecov/patch 72.89% of diff hit (target 66.57%)
Details
codecov/project 66.57% (+0%) compared to 4f0210d
Details
continuous-documentation/read-the-docs Read the Docs build succeeded!
Details
@utensil utensil added this to the 0.4.5 milestone Nov 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.