Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete vidcapture camera backend (3357) #1660

Closed
4 tasks
GalacticEmperor1 opened this issue Feb 12, 2023 · 0 comments · Fixed by #2207
Closed
4 tasks

Remove obsolete vidcapture camera backend (3357) #1660

GalacticEmperor1 opened this issue Feb 12, 2023 · 0 comments · Fixed by #2207
Labels
camera pygame.camera Code quality/robustness Code quality and resilience to changes Windows

Comments

@GalacticEmperor1
Copy link
Collaborator

Issue №3357 opened by Starbuck5 at 2022-07-31 05:49:08

Pygame's camera module, (src_py/camera.py) uses different strategies to try to get a working webcam backend.

At one point, videocapture / vidcapture was usable and used, another python library that could provide webcam functionality for Windows. However, that package is now obsolete (last updated in 2012), and we have a new camera backend for Windows now.

I'd like someone to remove this backend and relevant code.

  • update documentation ( camera docs, documented env variable in "pygame" doc? )
  • remove _camera_vidcapture.py source
  • remove vidcapture support from camera.py
  • figure out if there's something else I'm forgetting in this list that should be done

Comments

# # MyreMylar commented at 2022-07-31 13:22:06

What version of Windows does the new version of the camera backend support? IIRC it was 8 or was it 8.1?

Googling online suggests Windows 8.1 is EOL from Jan 2023.


# # Starbuck5 commented at 2022-08-02 03:00:59

What version of Windows does the new version of the camera backend support? IIRC it was 8 or was it 8.1?

It was unclear to me as I wrote it. It's been tested by Matiis, who runs some iteration of 8. (EDIT: confirmed, it was 8.1)

Seeing your comment reminds me that you actually were able to get vidcapture to work, I had forgotten anybody had in recent years. I was never able to get it to work locally.


# # MyreMylar commented at 2022-08-02 06:35:53

Yeah I got it working a while back, I think I just downloaded binary versions from that random python windows binary website on a university server - that is now being shut down.

Since then I've updated to a new PC and then Windows 11 and the new backend has been working fine on both Windows 10 and Windows 11 so I'm pretty sure it is safe to deprecate the old backend for new versions.

I expect the intersection of people who run pre-windows 8, managed to download the binary vidcapture backend before the website was shut down (or built it themselves from source) and still want to keep up to date on the latest versions of pygame is a very small number.


# # MVBarros commented at 2022-08-08 23:06:00

Hi. I would like to start contributing and this seems like a good first issue. Mind if I take it?


# # Starbuck5 commented at 2022-08-09 05:56:44

Hi. I would like to start contributing and this seems like a good first issue. Mind if I take it?

Sure, go ahead. I feel like a shill because I point this out a lot, but we have a # contributing channel on the pygame discord, if you want to ask questions in a more conversational format: https://discord.com/invite/ZuB2RySPRJ.


# # SmashedFrenzy16 commented at 2023-01-19 16:56:48

I'd like someone to remove this backend and relevant code.

Should't we keep it for legacy computers or at least make a new file for legacy camera modules? Many people still use operating systems like Windows 7.


# # SmashedFrenzy16 commented at 2023-01-19 16:59:31

But I get what you mean - Windows 7 iteself is losing market share rapidly. But we might want to keep it maybe until The end of this year or the start f the next? What do you think?


# # MyreMylar commented at 2023-01-19 18:54:48

I'd like someone to remove this backend and relevant code.

Should't we keep it for legacy computers or at least make a new file for legacy camera modules? Many people still use operating systems like Windows 7.

The older versions of pygame are still available, if you simply must have a pygame camera module that runs on an 14 year old end of life operating system - then pygame has plenty of old versions available for you to use.

@GalacticEmperor1 GalacticEmperor1 added camera pygame.camera Code quality/robustness Code quality and resilience to changes easy Windows labels Feb 12, 2023
@MightyJosip MightyJosip removed the easy label Feb 15, 2023
@novialriptide novialriptide linked a pull request Jun 17, 2023 that will close this issue
novialriptide added a commit that referenced this issue Jun 17, 2023
Remove obsolete vidcapture camera backend (#1660)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
camera pygame.camera Code quality/robustness Code quality and resilience to changes Windows
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants