Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete vidcapture camera backend (#1660) #2207

Merged
merged 8 commits into from
Jun 17, 2023

Conversation

that1guy232
Copy link
Contributor

@that1guy232 that1guy232 commented May 29, 2023

#1660
I very much imagine I am missing things.

@Starbuck5
Copy link
Member

Starbuck5 commented May 29, 2023

This looks pretty good to go from me. The only thing I notice straight away is that the docs should have a note that support was removed in this pygame version.

See ..versionchanged: tags in other bits of the docs source.

@Starbuck5 Starbuck5 added the camera pygame.camera label May 29, 2023
@that1guy232 that1guy232 marked this pull request as ready for review May 30, 2023 20:49
@that1guy232 that1guy232 requested a review from a team as a code owner May 30, 2023 20:49
@MyreMylar
Copy link
Member

The only other file I can find mentioning the Videocapture back end is here:

https://github.com/pygame-community/pygame-ce/blob/main/docs/reST/tutorials/en/intro-to-camera.rst

In the second paragraph/first 'Note' block.

As of Pygame 1.9, the camera module offers native support for cameras that use v4l2 on Linux. There is support for other platforms via Videocapture or OpenCV, but this guide will focus on the native module.

@that1guy232
Copy link
Contributor Author

The only other file I can find mentioning the Videocapture back end is here:

https://github.com/pygame-community/pygame-ce/blob/main/docs/reST/tutorials/en/intro-to-camera.rst

In the second paragraph/first 'Note' block.

As of Pygame 1.9, the camera module offers native support for cameras that use v4l2 on Linux. There is support for other platforms via Videocapture or OpenCV, but this guide will focus on the native module.

Good catch, I Think I got the last of it!

Copy link
Member

@Starbuck5 Starbuck5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@novialriptide novialriptide linked an issue Jun 17, 2023 that may be closed by this pull request
4 tasks
Copy link
Member

@novialriptide novialriptide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@novialriptide novialriptide merged commit 7ae1480 into pygame-community:main Jun 17, 2023
28 checks passed
@Starbuck5 Starbuck5 added this to the 2.3.1 milestone Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
camera pygame.camera
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove obsolete vidcapture camera backend (3357)
4 participants