Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise macOS deployment target to 10.11 #2171

Merged
merged 1 commit into from
Jul 2, 2023
Merged

Raise macOS deployment target to 10.11 #2171

merged 1 commit into from
Jul 2, 2023

Conversation

Starbuck5
Copy link
Member

@Starbuck5 Starbuck5 commented May 18, 2023 •
edited

@Starbuck5 Starbuck5 requested a review from a team as a code owner May 18, 2023 04:34
@Starbuck5 Starbuck5 marked this pull request as draft May 18, 2023 04:34
@yunline yunline added the CI Issue with the Continuous Integration (CI), the actions/bots that test things label Jun 4, 2023
@Starbuck5 Starbuck5 force-pushed the starbuck5-deps-updates branch 2 times, most recently from bde8247 to ebef4cd Compare June 30, 2023 19:26
@Starbuck5 Starbuck5 changed the title Try raising deployment target to 10.11 Raise macOS deployment target to 10.11 Jun 30, 2023
@Starbuck5 Starbuck5 marked this pull request as ready for review June 30, 2023 19:36
oddbookworm
oddbookworm approved these changes Jul 1, 2023
View reviewed changes
Copy link
Member

@oddbookworm oddbookworm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Starbuck5
Copy link
Member Author

Just put the CIBW_ENVIRONMENT variables back onto one line and squashed. That's the force push. Just to not have that unnecessary change in the diff.

ankith26
ankith26 approved these changes Jul 1, 2023
View reviewed changes
Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! 🥮

@Starbuck5 Starbuck5 merged commit 90490d3 into main Jul 2, 2023
27 checks passed
@Starbuck5 Starbuck5 added this to the 2.3.1 milestone Jul 2, 2023
@Starbuck5 Starbuck5 deleted the starbuck5-deps-updates branch July 2, 2023 00:49
@oddbookworm
Copy link
Member

I tested a wheel on an intel mac running MacOS 11.7.4, and it seems to work perfectly

This was referenced Jul 15, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankith26 ankith26 ankith26 approved these changes

@oddbookworm oddbookworm oddbookworm approved these changes

Assignees
No one assigned
Labels
CI Issue with the Continuous Integration (CI), the actions/bots that test things macOS
Projects
None yet
Milestone
2.3.1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Starbuck5 @oddbookworm @ankith26 @yunline