Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to SDL 2.26.5 #2318

Merged
merged 5 commits into from
Jul 17, 2023
Merged

Move to SDL 2.26.5 #2318

merged 5 commits into from
Jul 17, 2023

Conversation

Starbuck5
Copy link
Member

@Starbuck5 Starbuck5 commented Jul 15, 2023

This is mostly straightforward dep update.

The weird stuff is in the MacOS workflow, which is just a simplification and improvement of #2171 (getting our low mac target 10.11 for SDL 2.26.5)

Why not go to 2.28 directly? We're not ready for the screen/renderer exclusivity enforced in 2.28, also word on the street has some people talking about joysticks being broken in 2.28.

@Starbuck5 Starbuck5 requested a review from a team as a code owner July 15, 2023 09:05
@Starbuck5 Starbuck5 changed the title 2.26.5 Move to SDL 2.26.5 Jul 15, 2023
Copy link
Member

@oddbookworm oddbookworm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks 🎉

@ankith26 ankith26 merged commit b2f8784 into main Jul 17, 2023
28 checks passed
@ankith26 ankith26 added this to the 2.3.1 milestone Jul 17, 2023
@ankith26 ankith26 deleted the 2.26.5 branch July 17, 2023 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants