Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

font: ftfont should pass same tests as font #2180

Merged
merged 5 commits into from
Sep 2, 2023
Merged

font: ftfont should pass same tests as font #2180

merged 5 commits into from
Sep 2, 2023

Conversation

dr0id
Copy link
Contributor

@dr0id dr0id commented May 18, 2023

partial PR as requested in this PR #2132
this PR depends upon the 'stylename' property from PR #2175

@yunline yunline added tests tests (module) ftfont pygame.ftfont labels Jun 4, 2023
@dr0id dr0id marked this pull request as ready for review August 2, 2023 06:47
@dr0id dr0id requested a review from a team as a code owner August 2, 2023 06:47
@dr0id dr0id requested a review from Starbuck5 August 12, 2023 16:41
MyreMylar
MyreMylar approved these changes Aug 14, 2023
View reviewed changes
Copy link
Member

@MyreMylar MyreMylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@MyreMylar MyreMylar added this to the 2.3.2 milestone Aug 14, 2023
ankith26
ankith26 approved these changes Aug 30, 2023
View reviewed changes
Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

I don't think there are many users of ftfont but it's nice to get it consistent anyways

@ankith26 ankith26 merged commit 0168adc into pygame-community:main Sep 2, 2023
31 checks passed
@ankith26 ankith26 modified the milestones: 2.3.2, 2.4.0 Sep 2, 2023
ankith26 added a commit that referenced this pull request Sep 2, 2023
@ankith26
Merge pull request #2180 from dr0id/enhancement/font/add-missing-prop…
ccca226 
…erties

font: ftfont should pass same tests as font
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MyreMylar MyreMylar MyreMylar approved these changes

@ankith26 ankith26 ankith26 approved these changes

@Starbuck5 Starbuck5 Awaiting requested review from Starbuck5

Assignees
No one assigned
Labels
ftfont pygame.ftfont tests tests (module)
Projects
None yet
Milestone
2.3.2
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dr0id @MyreMylar @ankith26 @yunline